Skip to content

Build adjustments for code annotation #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Mar 13, 2025
Merged

Build adjustments for code annotation #2155

merged 37 commits into from
Mar 13, 2025

Conversation

nathanctech
Copy link
Contributor

This PR overrides Nuke's log handling and removes the problematic formatting the default analyzers were unable to process as well as improving the build flow to reduce duplicate warnings (and thus annotations). Building and testing have merged into a single step, and warnings are suppressed from the test rebuild since they're just refired from the initial build process anyway.

In addition, I adjusted the workflow so pushes to an existing pull request won't trigger both the push and PR builds to occur in some cases which also contributed to the warning duplication. In the end, file changes now have code-level annotations!

@nathanctech nathanctech requested a review from a team as a code owner December 24, 2024 03:02
wolfcomp
wolfcomp reviewed Dec 24, 2024
View reviewed changes
@KazWolfe KazWolfe self-assigned this Jan 3, 2025
KazWolfe
KazWolfe requested changes Jan 3, 2025
View reviewed changes
Copy link
Member

@KazWolfe KazWolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actions sets an environment variable (CI) to true. please only ensure these changes are only active when CI == true.

KazWolfe
KazWolfe reviewed Jan 3, 2025
View reviewed changes
@nathanctech
Copy link
Contributor Author

Well...git's quite something and re-commited a bunch of things despite my best efforts - anyway:

It now checks for the CI variable before doing any changes to the logging, so local builds will function as normal. I also added --skip-tests as a possible parameter in case those need to be skipped for some reason. You can technically still run tests without everything else locally by passing test as with the previous process and it will build as usual, too.

@wolfcomp
Copy link
Contributor

wolfcomp commented Jan 3, 2025

Maybe have skip test being the default on non CI builds?

@nathanctech
Copy link
Contributor Author

Maybe have skip test being the default on non CI builds?

Also an option, yeah. Then you could invoke it manually which would make sense since you're already having to do that with the current process. I can make that change if that's the way to go.

@KazWolfe
Copy link
Member

KazWolfe commented Jan 3, 2025

The other side is to have a ci-run target that does compile+test. That might be cleaner in general, though we'd need to probably look more into Nuke and how it works.

@nathanctech
Copy link
Contributor Author

The other side is to have a ci-run target that does compile+test. That might be cleaner in general, though we'd need to probably look more into Nuke and how it works.

From my research, the compile and test parameters being passed in the current process simply make Nuke trigger a given Target specification which then sets off the chain using the dependencies given. So, we could indeed have something like build.ps1 ci and have it trigger the build+test, with default being build only and untouched logging.

@nathanctech
Behavior change, now requires arg ci to be passed to trigger tests.…
2eb52a2 
… Tests can also be manually triggered with `test`.
@nathanctech
Copy link
Contributor Author

Okay. I scratched the skip-tests thing entirely. Now, the build process runs build.ps1 ci which triggers the test after building. When done locally with build.ps1 compile, it only runs the build step as expected.

@nathanctech nathanctech requested a review from KazWolfe January 21, 2025 17:06
@goaaats
Copy link
Member

goaaats commented Mar 13, 2025

Thank you! Really appreciate it, and sorry for taking so long on the merge!

@goaaats goaaats merged commit ee2c8dd into goatcorp:master Mar 13, 2025
goaaats pushed a commit that referenced this pull request Mar 13, 2025
@nathanctech @goaaats
Build adjustments for code annotation (#2155)
203d80c 
* Drop special formatting, allowing annotations to work properly.

* Suppress duplicate warnings, adding a prefix to prevent annotation

* Tweak message, don't rebuild on test

* Move testing into same job step

* Only run PR build on newly opened PRs

* flip build order, derp

* Test suppressing summary for annotations...

* Get the build order right, testing without conditionals...

* Run tests after compile, suppress warnings from test

* Reverted previous change to `main.yml`.

* Drop special formatting, allowing annotations to work properly.

* Suppress duplicate warnings, adding a prefix to prevent annotation

* Tweak message, don't rebuild on test

* Move testing into same job step

* Only run PR build on newly opened PRs

* flip build order, derp

* Test suppressing summary for annotations...

* Get the build order right, testing without conditionals...

* Run tests after compile, suppress warnings from test

* Reverted previous change to `main.yml`.

* Drop special formatting, allowing annotations to work properly.

* Suppress duplicate warnings, adding a prefix to prevent annotation

* Tweak message, don't rebuild on test

* Move testing into same job step

* Only run PR build on newly opened PRs

* flip build order, derp

* Test suppressing summary for annotations...

* Get the build order right, testing without conditionals...

* Run tests after compile, suppress warnings from test

* Reverted previous change to `main.yml`.

* Add conditional for CI builds, add --skip-tests to make up for the combined build/test step.

* Behavior change, now requires arg `ci` to be passed to trigger tests. Tests can also be manually triggered with `test`.
KirisameVanilla added a commit to KirisameVanilla/Dalamud that referenced this pull request Mar 24, 2025
@KirisameVanilla
Revert "Build adjustments for code annotation (goatcorp#2155)"
419daa4 
This reverts commit ee2c8dd.
goaaats pushed a commit to Soreepeong/Dalamud that referenced this pull request Apr 3, 2025
@nathanctech @goaaats
Build adjustments for code annotation (goatcorp#2155)
840442b 
* Drop special formatting, allowing annotations to work properly.

* Suppress duplicate warnings, adding a prefix to prevent annotation

* Tweak message, don't rebuild on test

* Move testing into same job step

* Only run PR build on newly opened PRs

* flip build order, derp

* Test suppressing summary for annotations...

* Get the build order right, testing without conditionals...

* Run tests after compile, suppress warnings from test

* Reverted previous change to `main.yml`.

* Drop special formatting, allowing annotations to work properly.

* Suppress duplicate warnings, adding a prefix to prevent annotation

* Tweak message, don't rebuild on test

* Move testing into same job step

* Only run PR build on newly opened PRs

* flip build order, derp

* Test suppressing summary for annotations...

* Get the build order right, testing without conditionals...

* Run tests after compile, suppress warnings from test

* Reverted previous change to `main.yml`.

* Drop special formatting, allowing annotations to work properly.

* Suppress duplicate warnings, adding a prefix to prevent annotation

* Tweak message, don't rebuild on test

* Move testing into same job step

* Only run PR build on newly opened PRs

* flip build order, derp

* Test suppressing summary for annotations...

* Get the build order right, testing without conditionals...

* Run tests after compile, suppress warnings from test

* Reverted previous change to `main.yml`.

* Add conditional for CI builds, add --skip-tests to make up for the combined build/test step.

* Behavior change, now requires arg `ci` to be passed to trigger tests. Tests can also be manually triggered with `test`.
AtmoOmen added a commit to AtmoOmen/Dalamud that referenced this pull request Jun 23, 2025
@AtmoOmen
Squashed commit of the following:
038ac8f 
commit 53707fa
Author: AtmoOmen <[email protected]>
Date:   Mon Jun 23 10:42:46 2025 +0800

    更新 7.2 上游

    # Conflicts:
    #	lib/FFXIVClientStructs   resolved by 7.2-7.1based version

commit b46e281
Author: AtmoOmen <[email protected]>
Date:   Mon Jun 23 10:39:26 2025 +0800

    更新 FFCS

commit a44943d
Author: AtmoOmen <[email protected]>
Date:   Sat Jun 21 13:55:26 2025 +0800

    更新 FFCS

commit 7db6fea
Author: AtmoOmen <[email protected]>
Date:   Thu Jun 5 19:30:17 2025 +0800

    更新 FFCS

commit 12ba8cb
Author: AtmoOmen <[email protected]>
Date:   Thu Jun 5 19:05:23 2025 +0800

    更新 LIB

commit 83a0ade
Merge: 63fdb4b 878d892
Author: AtmoOmen <[email protected]>
Date:   Thu Jun 5 19:05:14 2025 +0800

    Merge branch '7.2' into 7.2-7.1based

    # Conflicts:
    #	.github/workflows/main.yml
    #	.github/workflows/rollup.yml
    #	Dalamud.Injector/EntryPoint.cs
    #	Dalamud/Dalamud.csproj
    #	Dalamud/EntryPoint.cs
    #	Dalamud/Game/ChatHandlers.cs
    #	Dalamud/Interface/Internal/DalamudInterface.cs
    #	Dalamud/Interface/Internal/Windows/PluginInstaller/PluginInstallerWindow.cs
    #	Dalamud/Interface/Internal/Windows/Settings/Tabs/SettingsTabAutoUpdate.cs
    #	Dalamud/Interface/Internal/Windows/Settings/Tabs/SettingsTabExperimental.cs
    #	Dalamud/Plugin/Internal/Profiles/PluginManagementCommandHandler.cs
    #	Dalamud/Plugin/Internal/Types/LocalPlugin.cs
    #	Dalamud/Support/BugBait.cs
    #	Dalamud/Utility/Util.cs
    #	lib/CoreCLR/boot.cpp
    #	lib/FFXIVClientStructs   resolved by 7.2-7.1based version

commit 878d892
Author: bleatbot <[email protected]>
Date:   Tue Jun 3 03:07:19 2025 +0200

    Update ClientStructs (goatcorp#2286)

    Co-authored-by: github-actions[bot] <[email protected]>

commit 8ce676f
Author: goaaats <[email protected]>
Date:   Sun Jun 1 19:13:11 2025 +0200

    build: 12.0.1.2

commit e2609bb
Author: salanth357 <[email protected]>
Date:   Sat May 31 07:24:28 2025 -0400

    Improve performance in the Completion module (goatcorp#2288)

    Only resort the data entries when we modify the lists. Also use EncodeWithNullTerminator to ensure the safety of strings.

    Also avoid parsing the category names when we're only looking for the presence of the Dalamud category

commit a2f6fb8
Author: goaaats <[email protected]>
Date:   Sat May 31 13:20:54 2025 +0200

    Don't fade windows if we are docked or collapsed, for now
    The proper fix would be not to use the "fake window" approach and insert a drawlist, but not with the current bindings

commit abde79d
Author: goaaats <[email protected]>
Date:   Sat May 31 12:00:40 2025 +0200

    Re-add toggle window commands to CorePlugin

commit eb34eb1
Author: goaaats <[email protected]>
Date:   Sat May 31 12:00:20 2025 +0200

    Fix some warnings

commit bf0dbde
Author: goaaats <[email protected]>
Date:   Thu May 29 21:08:03 2025 +0200

    Completion: Don't create Utf8String before the game has initialized

commit 84d121c
Author: salanth357 <[email protected]>
Date:   Thu May 29 14:24:21 2025 -0400

    Add Completion module (goatcorp#2274)

    * Add Completion module

    Dalamud and plugin commands will now be tab-completable in the ChatLog

    * PR feedback

    ---------

    Co-authored-by: goat <[email protected]>

commit 944c370
Author: goaaats <[email protected]>
Date:   Thu May 29 19:40:32 2025 +0200

    build: 12.0.1.1

commit ed8a455
Author: bleatbot <[email protected]>
Date:   Thu May 29 19:39:03 2025 +0200

    Update ClientStructs (goatcorp#2280)

    Co-authored-by: github-actions[bot] <[email protected]>

commit 911999e
Author: Haselnussbomber <[email protected]>
Date:   Thu May 29 19:38:29 2025 +0200

    Update AddonEventType (goatcorp#2279)

commit e20f132
Author: Haselnussbomber <[email protected]>
Date:   Thu May 29 19:38:10 2025 +0200

    Add ISeStringEvaluator.EvaluateMacroString (goatcorp#2281)

commit 3f3a1f2
Author: Haselnussbomber <[email protected]>
Date:   Thu May 29 19:37:48 2025 +0200

    Add support for sheet payload links (goatcorp#2282)

    * Fix "Print Evaluated" not evaluating with context

    * Add support for sheet payload links

commit e52e0b6
Author: Haselnussbomber <[email protected]>
Date:   Thu May 29 19:35:38 2025 +0200

    Scrollable Self-Test table (goatcorp#2284)

commit e415699
Author: srkizer <[email protected]>
Date:   Fri May 30 00:06:48 2025 +0900

    DrawListTextureWrap: use two textures (goatcorp#2285)

    Making premultiplied pixel data into straight alpha in-place using UAV
    seems to be not working on older graphics cards. Now every instance of
    DrawListTextureWrap keeps two GPU textures, where one keeps a
    premultiplied data which will be written to using ImGui draw data and
    read from to calculate straight alpha pixel data.

commit d80202a
Author: goaaats <[email protected]>
Date:   Tue May 27 22:50:02 2025 +0200

    build: 12.0.1.0

commit 544eb39
Author: Aireil <[email protected]>
Date:   Tue May 27 20:58:29 2025 +0200

    Add new kinds to FlyTextKind enum (goatcorp#2278)

commit a12147c
Author: bleatbot <[email protected]>
Date:   Tue May 27 17:56:34 2025 +0200

    Update ClientStructs (goatcorp#2276)

    Co-authored-by: github-actions[bot] <[email protected]>

commit 452ff3a
Author: bleatbot <[email protected]>
Date:   Mon May 26 21:16:58 2025 +0200

    Update ClientStructs (goatcorp#2269)

    Co-authored-by: github-actions[bot] <[email protected]>

commit fe8efc9
Author: MidoriKami <[email protected]>
Date:   Mon May 26 12:09:50 2025 -0700

    UIDebug2 Timeline Labelset support (goatcorp#2275)

    * Add LabelSet Display

    * Update TimelineTree.cs

commit 43ab6f6
Author: MidoriKami <[email protected]>
Date:   Fri May 23 15:44:24 2025 -0700

    UiDebug2 Misc Fixes (goatcorp#2273)

    * Fix incorrect type check

    * Fix address calculation

commit 15352a3
Author: goaaats <[email protected]>
Date:   Sat May 17 12:57:55 2025 +0200

    Upgrade to goatcorp.Reloaded.Hooks 4.2.0-goatcorp5
    Possibly fixes an issue with Wine 10

commit 421d8ce
Author: goaaats <[email protected]>
Date:   Sat May 10 19:31:06 2025 +0200

    Revert "Respect fadein/out for Window.DrawConditions() and Window.IsOpen"

    This reverts commit c33a534.

commit c33a534
Author: goaaats <[email protected]>
Date:   Sat May 10 18:37:34 2025 +0200

    Respect fadein/out for Window.DrawConditions() and Window.IsOpen

commit 5c33d15
Author: goaaats <[email protected]>
Date:   Sat May 10 14:21:30 2025 +0200

    Add Window.OnSafeToRemove(), tune timings a bit more

commit e9aa2e2
Author: goaaats <[email protected]>
Date:   Sat May 10 13:23:32 2025 +0200

    Respect alpha when drawing installer loading overlay

commit 271c258
Author: goaaats <[email protected]>
Date:   Sat May 10 13:16:12 2025 +0200

    Add per-window opt-out for fades

commit 9afece8
Author: goaaats <[email protected]>
Date:   Sat May 10 13:08:24 2025 +0200

    Improve fade-in, use delta time, draw fade-out texture on fake window to preserve focus order

commit b4e6257
Author: goaaats <[email protected]>
Date:   Sat May 10 01:10:53 2025 +0200

    Add option to auto-update disabled plugins

commit b1c874c
Author: goaaats <[email protected]>
Date:   Fri May 9 23:40:49 2025 +0200

    Fade in/out window system windows

commit 2c735e9
Author: Haselnussbomber <[email protected]>
Date:   Fri May 9 23:10:35 2025 +0200

    Do not throw ObjectDisposedException in IsEnabled and Disable (goatcorp#2266)

commit bf49152
Author: goaaats <[email protected]>
Date:   Fri May 9 23:05:38 2025 +0200

    Upgrade cimgui, use custom FindWindowByName instead of hardcoded offset

commit 33605e3
Author: Haselnussbomber <[email protected]>
Date:   Fri May 9 22:53:44 2025 +0200

    Move AntiDebug to xivfixes (goatcorp#2264)

    * Move AntiDebug to xivfixes

    * Update BootEnabledGameFixes

    * Check BootEnabledGameFixes

    * Apply suggestions from code review

    Co-authored-by: KazWolfe <[email protected]>

    ---------

    Co-authored-by: KazWolfe <[email protected]>

commit 4dce0c0
Author: srkizer <[email protected]>
Date:   Sat May 10 05:47:42 2025 +0900

    Implement DrawListTextureWrap (goatcorp#2036)

    * Implement DrawListTextureWrap

    * Fix unloading

    * minor fixes

    * Add CreateFromClipboardAsync

    ---------

    Co-authored-by: goat <[email protected]>

commit a12c63d
Author: goaaats <[email protected]>
Date:   Fri May 9 22:08:09 2025 +0200

    Fix notification positioning when multi-monitor is enabled

commit df8de39
Author: goaaats <[email protected]>
Date:   Wed May 7 23:49:32 2025 +0200

    Even more boot load logging

commit ac14d61
Author: goaaats <[email protected]>
Date:   Wed May 7 22:40:05 2025 +0200

    Add some more logging to boot plugin loads

commit 5c5ce37
Author: goaaats <[email protected]>
Date:   Wed May 7 22:38:10 2025 +0200

    Fix docs warning

commit 50fdc2e
Author: goaaats <[email protected]>
Date:   Wed May 7 00:00:48 2025 +0200

    TSM should force itself to front if it is expanded

commit 2b49170
Author: goaaats <[email protected]>
Date:   Wed May 7 00:00:32 2025 +0200

    Add configurable "anchor position" for notifications

commit 20ef5fb
Author: goaaats <[email protected]>
Date:   Sat May 3 17:47:44 2025 +0200

    build: 12.0.0.15

commit 09f519c
Author: foophoof <[email protected]>
Date:   Fri May 2 05:05:42 2025 +0100

    Convert PluginStatWindow to ImRaii (goatcorp#2268)

    Currently the Hooks tab asserts because of a missing ImGui.EndTabItem. Instead of just adding that, I took the opportunity to convert everything to use ImRaii instead.

commit 85b7722
Author: goaaats <[email protected]>
Date:   Fri May 2 02:21:34 2025 +0200

    Clarify wording in settings and error notifications

commit 5304c9a
Author: goaaats <[email protected]>
Date:   Fri May 2 02:13:24 2025 +0200

    Fix CS obsoletion

commit 60ca710
Author: goaaats <[email protected]>
Date:   Fri May 2 00:10:15 2025 +0200

    build: 12.0.0.14

commit 9872274
Author: bleatbot <[email protected]>
Date:   Thu May 1 20:59:03 2025 +0200

    Update ClientStructs (goatcorp#2263)

    Co-authored-by: github-actions[bot] <[email protected]>

commit 30b5c0b
Author: Haselnussbomber <[email protected]>
Date:   Thu May 1 20:49:30 2025 +0200

    Update ConditionFlag (goatcorp#2265)

commit ddf0a97
Author: goaaats <[email protected]>
Date:   Thu May 1 20:47:03 2025 +0200

    Add plugin error notifications, per-plugin event invocation wrappers

commit 1913a4c
Author: goaaats <[email protected]>
Date:   Thu May 1 16:38:57 2025 +0200

    Provide services in the same order in Debug and Release

commit 22430ce
Author: goaaats <[email protected]>
Date:   Thu May 1 14:45:51 2025 +0200

    Make ConsoleManagerPluginScoped internal as it's supposed to be

commit 69d8968
Author: goaaats <[email protected]>
Date:   Thu May 1 14:45:25 2025 +0200

    IoC: Allow private scoped objects to resolve singleton services

commit c82bb81
Author: goaaats <[email protected]>
Date:   Sat Apr 26 21:52:45 2025 +0200

    Show exception in service init error message

commit febf4e5
Author: bleatbot <[email protected]>
Date:   Mon Apr 28 21:38:30 2025 +0200

    Update ClientStructs (goatcorp#2260)

    Co-authored-by: github-actions[bot] <[email protected]>

commit fd1eafd
Author: Asriel <[email protected]>
Date:   Mon Apr 28 12:13:48 2025 -0700

    Update Lumina to 5.7.0 and Lumina.Excel to 7.2.2 (goatcorp#2258)

commit f5d93fb
Merge: 82cdcf0 b810154
Author: goat <[email protected]>
Date:   Mon Apr 28 21:09:40 2025 +0200

    Add MinimumDalamudVersion to manifest, validate at install, update and load (goatcorp#2248)

commit 82cdcf0
Author: Haselnussbomber <[email protected]>
Date:   Sat Apr 26 19:19:51 2025 +0200

    Use GameInventoryType in InventoryWidget (goatcorp#2257)

commit ced601e
Author: goaaats <[email protected]>
Date:   Sat Apr 26 12:48:07 2025 +0200

    build: 12.0.0.13

commit 4633820
Author: goaaats <[email protected]>
Date:   Sat Apr 26 12:17:52 2025 +0200

    build: 12.0.0.12

commit a925e37
Author: goaaats <[email protected]>
Date:   Sat Apr 26 12:17:27 2025 +0200

    Actually respect remember state flag

commit 0bddf30
Author: Aireil <[email protected]>
Date:   Sat Apr 26 01:28:12 2025 +0200

    Fix fly text combo in Dalamud Data (goatcorp#2262)

commit b25fceb
Author: goaaats <[email protected]>
Date:   Fri Apr 25 23:01:01 2025 +0200

    build: 12.0.0.11

commit 06851ab
Author: goaaats <[email protected]>
Date:   Fri Apr 25 22:59:04 2025 +0200

    Add separators between profiles and entries for better visual clarity

commit 731d7e0
Author: goaaats <[email protected]>
Date:   Fri Apr 25 22:48:26 2025 +0200

    Un-whether-or-not the codebase

commit f4102db
Author: goaaats <[email protected]>
Date:   Fri Apr 25 22:46:30 2025 +0200

    Add "startup behavior" to profiles
    Choose between remember, always enable, always disable

commit 08f9594
Author: goaaats <[email protected]>
Date:   Fri Apr 25 22:12:39 2025 +0200

    Add "restart in safe mode" button to blocked message

commit 999e3ea
Author: goaaats <[email protected]>
Date:   Fri Apr 25 21:43:27 2025 +0200

    ForceSave() when enabling safe mode from the exception window

commit 0db49a5
Author: goaaats <[email protected]>
Date:   Fri Apr 25 21:43:10 2025 +0200

    DalamudConfiguration.ForceSave should wait for the save task to exit

commit ce49b0d
Author: Haselnussbomber <[email protected]>
Date:   Fri Apr 25 20:59:44 2025 +0200

    SeStringEvaluator: fallback to games ClientLanguage (goatcorp#2261)

commit b996ff5
Author: goaaats <[email protected]>
Date:   Fri Apr 25 19:01:56 2025 +0200

    Theme progress bars and plots by default

commit f482bad
Author: goaaats <[email protected]>
Date:   Fri Apr 25 18:53:30 2025 +0200

    Add progress bar to boot plugin loads, show which are pending

commit e29171c
Author: goaaats <[email protected]>
Date:   Thu Apr 24 21:58:54 2025 +0200

    Fix race condition in plugin load
    When opening the installer while boot plugins are still loaded, it may have been possible for plugins to be added to the installed plugins list twice, causing various statekeeping issues

commit 096f9c3
Author: bleatbot <[email protected]>
Date:   Thu Apr 24 19:51:53 2025 +0200

    Update ClientStructs (goatcorp#2256)

    Co-authored-by: github-actions[bot] <[email protected]>

commit d881fea
Author: goaaats <[email protected]>
Date:   Tue Apr 22 21:53:23 2025 +0200

    build: 12.0.0.10

commit a9299b4
Author: Aireil <[email protected]>
Date:   Tue Apr 22 21:03:06 2025 +0200

    Add Dataset to FlyTextKind enum (goatcorp#2255)

commit 4995383
Author: bleatbot <[email protected]>
Date:   Tue Apr 22 16:44:43 2025 +0200

    Update ClientStructs (goatcorp#2244)

    Co-authored-by: github-actions[bot] <[email protected]>

commit cf5a6f2
Author: Tupae <[email protected]>
Date:   Tue Apr 22 16:34:36 2025 +0200

    Add a command line for multimonitor toogle (goatcorp#2254)

    * Update DalamudCommands.cs

    Added a /xlmulti command for toggling multimonitor.

    Using Dalamud local build encounters Assertion Failure with Umbra plugin enabled. Otherwise works fine.

    * Update DalamudCommands.cs

    replaced /xlmulti with /xltogglemultimonitor to be more explicit

    ---------

    Co-authored-by: Fractal <Fractal@FRACTAL>

commit aea6273
Author: Haselnussbomber <[email protected]>
Date:   Tue Apr 22 16:34:19 2025 +0200

    Safer AddonEventManager node removal (goatcorp#2232)

    * Remove events on Framework thread

    * Make sure the addon is not unloaded

    * Cleanup node finding loop

    * Wait for PluginEventController to be disposed

commit 61a17da
Author: Haselnussbomber <[email protected]>
Date:   Mon Apr 21 14:02:26 2025 +0200

    SeString Creator and Evaluator fixes (goatcorp#2250)

    * Fix SeString Creator example

    * SeStringEvaluator: Don't print auto translation brackets for categories

    * SeStringEvaluator: Fix map id mask

    MapId is a ushort, not a byte.

commit 39ac9f9
Author: Haselnussbomber <[email protected]>
Date:   Mon Apr 21 14:01:59 2025 +0200

    Make ItemUtil public (goatcorp#2252)

commit c7cc771
Author: goaaats <[email protected]>
Date:   Sun Apr 20 15:16:46 2025 +0200

    Upgrade Reloaded.Hooks/Reloaded.Assembler to address concurrency problems

commit 672793b
Author: goaaats <[email protected]>
Date:   Thu Apr 17 17:14:25 2025 +0200

    Add hook stress test

commit 81ced56
Author: Haselnussbomber <[email protected]>
Date:   Tue Apr 15 23:44:10 2025 +0200

    Better ImGui setup condition (goatcorp#2249)

    * Better ImGui setup condition

    * Fix build

commit cb8d9cc
Author: goaaats <[email protected]>
Date:   Tue Apr 15 21:43:08 2025 +0200

    Replace update message with link to changelog
    ...instead of pointing to Discord

commit af1eb27
Author: Cytraen <[email protected]>
Date:   Tue Apr 15 15:33:28 2025 -0400

    sort by search score in plugin installer if opened w/ search text (goatcorp#2246)

commit b810154
Author: goaaats <[email protected]>
Date:   Tue Apr 15 21:29:18 2025 +0200

    Add MinimumDalamudVersion to manifest, validate at install, update and load

commit 3f72417
Author: goaaats <[email protected]>
Date:   Tue Apr 15 21:14:24 2025 +0200

    Fix a warning

commit 2f0c57d
Author: goaaats <[email protected]>
Date:   Tue Apr 15 19:12:07 2025 +0200

    Reassign leftover Api12ToDo to Api13ToDo

commit 1841014
Author: goaaats <[email protected]>
Date:   Mon Apr 14 21:33:50 2025 +0200

    build: 12.0.0.9

commit e52ac55
Author: KazWolfe <[email protected]>
Date:   Mon Apr 14 10:57:56 2025 -0700

    deps: bump clientstructs (goatcorp#2243)

    - fix fate HasExpBonus
    - remove deprecation from concrete class
      - kept on interface

commit 708f3d0
Author: nebel <[email protected]>
Date:   Tue Apr 15 02:54:53 2025 +0900

    Improve null checking for badly set properties in NamePlateGui (goatcorp#2245)

commit 2787e37
Author: goaaats <[email protected]>
Date:   Sat Apr 12 12:18:08 2025 +0200

    build: 12.0.0.8

commit 26aaf97
Author: Blair <[email protected]>
Date:   Thu Apr 10 06:16:51 2025 +1000

    Add menu functions to ImRaii (goatcorp#2227)

commit 98c5fbd
Author: Haselnussbomber <[email protected]>
Date:   Wed Apr 9 22:16:28 2025 +0200

    Update AddonEventType (goatcorp#2238)

    * Update AddonEventType

    * Fix copy paste mistake

commit a555514
Author: Blair <[email protected]>
Date:   Thu Apr 10 06:15:09 2025 +1000

    Show correct changelog in plugin installer window (goatcorp#2236)

commit d3dd3ab
Author: Ottermandias <[email protected]>
Date:   Wed Apr 9 22:14:47 2025 +0200

    Add configurable default sorting to FileDialog. (goatcorp#2233)

commit bc18198
Author: Haselnussbomber <[email protected]>
Date:   Wed Apr 9 22:13:27 2025 +0200

    Fix kilo macro not having thousands separators (goatcorp#2237)

commit 499952b
Author: Haselnussbomber <[email protected]>
Date:   Wed Apr 9 22:13:11 2025 +0200

    SeStringEvaluator: Fix HeadAll not capitalizing correctly (goatcorp#2240)

    * Fix obsoletes

    * Fix HeadAll not capitalizing correctly

    * Fix incorrect denoun cases in SeString Creator

    * Implement Utf8String.ToUpper in C#

    * Handle characters with accents too

    * Add remarks to ToUpper functions

commit f96e2ae
Author: Haselnussbomber <[email protected]>
Date:   Sun Apr 6 23:36:26 2025 +0200

    Fix reading world name for PcName (goatcorp#2235)

commit 4896832
Author: Haselnussbomber <[email protected]>
Date:   Sun Apr 6 23:30:45 2025 +0200

    Update ConditionFlag enum (goatcorp#2234)

commit 97b01d6
Author: goaaats <[email protected]>
Date:   Thu Apr 3 19:15:12 2025 +0200

    Delay IM hook setup to after the game sets up rendering
    This seems to (hack)fix some odd behavior around shader caching as reported by various users.

commit f812bf8
Author: goaaats <[email protected]>
Date:   Thu Apr 3 00:53:28 2025 +0200

    Correctly test Framework Run vs. RunOnTick

commit c1805bd
Author: goaaats <[email protected]>
Date:   Thu Apr 3 00:37:20 2025 +0200

    Fix warning

commit ca438b6
Author: goaaats <[email protected]>
Date:   Thu Apr 3 00:32:37 2025 +0200

    Add self-test for framework task scheduling

commit 810611e
Author: goaaats <[email protected]>
Date:   Thu Apr 3 00:17:20 2025 +0200

    Add "jump to" button to self-test window

commit 7286d97
Author: goaaats <[email protected]>
Date:   Thu Apr 3 00:03:16 2025 +0200

    Add question to toast self test

commit d2cae32
Author: goaaats <[email protected]>
Date:   Wed Apr 2 22:38:28 2025 +0200

    AgingSteps => SelfTestSteps

commit 95bac80
Author: goaaats <[email protected]>
Date:   Tue Apr 1 23:16:28 2025 +0200

    Remove 2025 april fools

commit 5eee678
Author: goaaats <[email protected]>
Date:   Tue Apr 1 23:15:31 2025 +0200

    Unify body notice drawing logic, clear search when switching groups

commit 34ca8b8
Author: goaaats <[email protected]>
Date:   Tue Apr 1 19:58:19 2025 +0200

    Fix updates failing due to flipped WorkingPluginId check

commit 34679d0
Author: goaaats <[email protected]>
Date:   Tue Apr 1 18:55:27 2025 +0200

    Extract plugin to temp directory before copying to final location, some minor cleanup

commit f2c89bf
Author: goaaats <[email protected]>
Date:   Tue Apr 1 01:54:01 2025 +0200

    build: 12.0.0.7

commit 2a049c4
Author: goaaats <[email protected]>
Date:   Tue Apr 1 01:53:14 2025 +0200

    Make it lame again

commit 4a1f782
Author: goaaats <[email protected]>
Date:   Tue Apr 1 01:28:05 2025 +0200

    build: 12.0.0.6

commit c67ed34
Author: goaaats <[email protected]>
Date:   Tue Apr 1 01:27:44 2025 +0200

    Add prizes

commit 46c0a86
Author: goaaats <[email protected]>
Date:   Mon Mar 31 22:51:28 2025 +0200

    build: 12.0.0.5

commit 104504f
Author: goaaats <[email protected]>
Date:   Mon Mar 31 22:37:41 2025 +0200

    Add 2025 april fools

commit 3d04d75
Author: goaaats <[email protected]>
Date:   Mon Mar 31 18:31:00 2025 +0200

    build: 12.0.0.4

commit 126e966
Author: KazWolfe <[email protected]>
Date:   Mon Mar 31 09:25:47 2025 -0700

    fix: Repair broken contextmenu test (goatcorp#2231)

    - Bump clientstructs

commit d86232d
Author: bleatbot <[email protected]>
Date:   Sun Mar 30 22:51:42 2025 +0200

    Update ClientStructs (goatcorp#2228)

    Co-authored-by: github-actions[bot] <[email protected]>

commit 7cb0d61
Author: goaaats <[email protected]>
Date:   Sat Mar 29 20:09:26 2025 +0100

    Use RunOnTick instead

commit dac14b9
Author: goaaats <[email protected]>
Date:   Sat Mar 29 20:04:41 2025 +0100

    Add test for fastfail exception

commit 813bb1d
Author: goaaats <[email protected]>
Date:   Sat Mar 29 19:06:48 2025 +0100

    build: 12.0.0.3

commit 37ca457
Author: bleatbot <[email protected]>
Date:   Sat Mar 29 18:54:10 2025 +0100

    Update ClientStructs (goatcorp#2226)

    Co-authored-by: github-actions[bot] <[email protected]>

commit a9fd92a
Author: bleatbot <[email protected]>
Date:   Sat Mar 29 06:53:25 2025 +0100

    Update ClientStructs (goatcorp#2224)

    Co-authored-by: github-actions[bot] <[email protected]>

commit 106b59d
Author: goaaats <[email protected]>
Date:   Fri Mar 28 23:25:38 2025 +0100

    build: 12.0.0.2

commit 0e87856
Author: Haselnussbomber <[email protected]>
Date:   Fri Mar 28 23:16:17 2025 +0100

    Remove MateriaSlotCount check (goatcorp#2223)

commit 541c073
Author: goaaats <[email protected]>
Date:   Fri Mar 28 22:41:00 2025 +0100

    build: 12.0.0.1

commit 0d9eca1
Author: Haselnussbomber <[email protected]>
Date:   Fri Mar 28 19:32:23 2025 +0100

    Fix GameInventoryItem array initialization (goatcorp#2222)

commit baf796f
Author: bleatbot <[email protected]>
Date:   Fri Mar 28 18:51:54 2025 +0100

    Update ClientStructs (goatcorp#2221)

    Co-authored-by: github-actions[bot] <[email protected]>

commit b28fab2
Author: Haselnussbomber <[email protected]>
Date:   Fri Mar 28 17:19:25 2025 +0100

    More InvokeSafely calls (goatcorp#2215)

    * Safely invoke DutyState event handlers

    * Safely invoke GameGui event handlers

commit c1557df
Author: bleatbot <[email protected]>
Date:   Fri Mar 28 17:07:55 2025 +0100

    Update ClientStructs (goatcorp#2216)

    Co-authored-by: github-actions[bot] <[email protected]>

commit e5e3b27
Author: Bloodsoul <[email protected]>
Date:   Fri Mar 28 17:07:35 2025 +0100

    Update FateState.cs (goatcorp#2218)

    Updating to 7.2 according to related changes in CS
    aers/FFXIVClientStructs@01c4dfe

commit 6160252
Author: Haselnussbomber <[email protected]>
Date:   Fri Mar 28 17:00:14 2025 +0100

    Update GameInventoryItem (goatcorp#2219)

    * Update GameInventoryItem

    - Resolve symbolic InventoryItem, used in HandIn
    - Harden Materia/MateriaGrade/Stains results
    - Make sure GameInventoryItem is constructed correctly

    * Remove some duplicate code from InventoryWidget

    * Fix null check

commit f5b3d85
Author: Haselnussbomber <[email protected]>
Date:   Fri Mar 28 16:57:39 2025 +0100

    Bump Lumina.Excel to 7.2.1 (goatcorp#2220)

commit fb61d72
Author: goaaats <[email protected]>
Date:   Fri Mar 28 00:51:59 2025 +0100

    Remove legacy corrupted state exceptions entirely

commit 9c80b72
Author: KazWolfe <[email protected]>
Date:   Thu Mar 27 16:48:12 2025 -0700

    deps: bump clientstructs (goatcorp#2217)

    - and fix the errors

commit 6dddfa1
Author: bleatbot <[email protected]>
Date:   Thu Mar 27 03:57:35 2025 +0100

    Update ClientStructs (goatcorp#2213)

    Co-authored-by: github-actions[bot] <[email protected]>

commit 0a06a9c
Author: AllunEve <[email protected]>
Date:   Thu Mar 27 03:48:32 2025 +0100

    Astral fire and Umbral ice are Gone. (goatcorp#2214)

    Co-authored-by: Alluneve <[email protected]>

commit 46ed621
Author: Caraxi <[email protected]>
Date:   Thu Mar 27 09:50:37 2025 +1030

    Add BitmapFontIcons from 7.2 (goatcorp#2212)

commit f94f03e
Merge: 202da06 8320a82
Author: goaaats <[email protected]>
Date:   Wed Mar 26 20:44:48 2025 +0100

    Merge branch 'api12'

commit 202da06
Author: goat <[email protected]>
Date:   Wed Mar 26 20:43:09 2025 +0100

    ci: disable rollup

commit 8320a82
Author: marzent <[email protected]>
Date:   Wed Mar 26 20:38:27 2025 +0100

    return an error HRESULT when dotnet runtime can't be found (goatcorp#2209)

commit 19ba6a9
Author: Blair <[email protected]>
Date:   Thu Mar 27 05:36:18 2025 +1000

    Switch INotificationManager and ITitleScreenMenu to use ISharedImmediateTexture (goatcorp#1879)

    * Switch INotificationManager and ITitleScreenMenu to use ISharedImmediateTexture goatcorp#1879

    * Remove SetIconTexture
    Remove some remarks that no longer apply

    * Cleanup StyleCop warnings

commit 81bc001
Author: Kaz Wolfe <[email protected]>
Date:   Wed Mar 26 12:12:36 2025 -0700

    more cs bumpies uwu

    - boing
    - boing
    - boing

commit 4942915
Author: Kaz Wolfe <[email protected]>
Date:   Wed Mar 26 09:52:07 2025 -0700

    *CS bumping noises*

commit 43e3804
Author: Aireil <[email protected]>
Date:   Wed Mar 26 04:25:10 2025 +0100

    Fix FlyTextKind enum (goatcorp#2207)

    * Fix FlyTextKind enum

    * Remove the experimental tags

commit 2f02956
Author: Haselnussbomber <[email protected]>
Date:   Wed Mar 26 01:32:24 2025 +0100

    Fixing colors and NounResolver (goatcorp#2208)

    * Fixing colors and NounResolver

    * Remove failing special case NounProcessor selftest

commit cba1a7d
Author: Kaz Wolfe <[email protected]>
Date:   Tue Mar 25 16:17:21 2025 -0700

    fix: AddonLifecycle sig, cs bump

commit dc30651
Author: Kaz Wolfe <[email protected]>
Date:   Tue Mar 25 13:02:20 2025 -0700

    deps: bump cs

commit abb5cf5
Author: marzent <[email protected]>
Date:   Tue Mar 25 18:43:18 2025 +0100

    fix wine_get_host_version calling convention (goatcorp#2206)

commit fe5ce40
Author: Haselnussbomber <[email protected]>
Date:   Tue Mar 25 17:38:21 2025 +0100

    Fix ISeStringEvaluator service not resolving (goatcorp#2204)

commit 0377e84
Author: Haselnussbomber <[email protected]>
Date:   Tue Mar 25 17:37:18 2025 +0100

    Config Options for 7.2 (goatcorp#2205)

commit c5af536
Author: Kaz Wolfe <[email protected]>
Date:   Tue Mar 25 09:35:21 2025 -0700

    docs: Explain what the UI*Payloads actually are.

commit 67561af
Author: Kaz Wolfe <[email protected]>
Date:   Tue Mar 25 09:28:57 2025 -0700

    fix: Lumina updates

commit 12ce098
Author: Kaz Wolfe <[email protected]>
Date:   Tue Mar 25 09:10:00 2025 -0700

    deps: bump deps

    - Lumina.Excel to 7.2.0
    - ClientStructs to latest

    Co-authored-by: Asriel Camora <[email protected]>

commit 919ca87
Author: Kaz Wolfe <[email protected]>
Date:   Mon Mar 24 21:58:23 2025 -0700

    update clientstructs

    - fix broken gamepad sig by delegating to CS

commit 445fe09
Author: Kaz Wolfe <[email protected]>
Date:   Mon Mar 24 18:50:39 2025 -0700

    fix: dalamud boot deadlock over wine

commit 27dc659
Author: Kaz Wolfe <[email protected]>
Date:   Mon Mar 24 18:32:44 2025 -0700

    chore: Convert AsLuminaSeString to AsReadOnlySeString

    - Somewhat more useful, or so one would hope.

commit a7509ef
Author: Kaz Wolfe <[email protected]>
Date:   Mon Mar 24 18:16:39 2025 -0700

    feat: More utilities!

    - Also document that CStringExtensions only works with bundled CS.

commit 314c046
Author: Kaz Wolfe <[email protected]>
Date:   Mon Mar 24 17:43:49 2025 -0700

    feat: Add CStringPointer#ExtractText

    - Move CString extensions to their own class.
    - Add some words to our dictionary.

commit ddda4d4
Author: goaaats <[email protected]>
Date:   Mon Mar 24 21:54:57 2025 +0100

    Make VS happy about SLN changes

commit 24358f5
Author: goaaats <[email protected]>
Date:   Mon Mar 24 21:41:55 2025 +0100

    Fix warning in injector

commit 5dcd1cc
Author: Kaz Wolfe <[email protected]>
Date:   Mon Mar 24 13:35:42 2025 -0700

    chore: fix angry compiler

commit 9a25946
Author: goaaats <[email protected]>
Date:   Mon Mar 24 21:28:41 2025 +0100

    Associate Dalamud.Common and LocExporter with x64 configs

commit 2176b32
Author: Kaz Wolfe <[email protected]>
Date:   Mon Mar 24 13:25:13 2025 -0700

    chore: Bump ClientStructs and make it build again

commit 9e3c03d
Author: goaaats <[email protected]>
Date:   Mon Mar 24 20:45:16 2025 +0100

    Add deprecation warning to targets file

commit d1e6e34
Author: goaaats <[email protected]>
Date:   Mon Mar 24 20:44:57 2025 +0100

    Bump to version 12

commit f209ac0
Author: goaaats <[email protected]>
Date:   Mon Mar 24 20:23:56 2025 +0100

    SeStringEvaluator: Throw if not on main thread

commit 84f5dad
Author: Kaz Wolfe <[email protected]>
Date:   Mon Mar 24 11:31:19 2025 -0700

    fix: JobGauge enum casing

commit c0c61c6
Author: goaaats <[email protected]>
Date:   Mon Mar 24 19:21:04 2025 +0100

    Fix warnings

commit fc56277
Author: goaaats <[email protected]>
Date:   Mon Mar 24 19:19:44 2025 +0100

    Rename SMN enums to follow code standards

commit 61a4f3b
Author: goaaats <[email protected]>
Date:   Mon Mar 24 19:17:59 2025 +0100

    Re-remove obsolete ServicePointManager TLS version override

commit a130515
Author: goaaats <[email protected]>
Date:   Mon Mar 24 19:17:43 2025 +0100

    Remove unused enumerator object pool from ObjectTable

commit daeb923
Author: goaaats <[email protected]>
Date:   Mon Mar 24 19:16:52 2025 +0100

    Add missing declaration for utils::is_running_on_wine()

commit 30cadef
Author: Kaz Wolfe <[email protected]>
Date:   Mon Mar 24 09:12:13 2025 -0700

    fix: support XL_PLATFORM as well (hopefully)

commit fdbfdbb
Author: Haselnussbomber <[email protected]>
Date:   Mon Mar 24 17:00:27 2025 +0100

    Add SeStringEvaluator service (goatcorp#2188)

    * Add SeStringEvaluator service

    * Move DrawCopyableText into WidgetUtil

    * Use Icon2RemapTable in SeStringRenderer

    * Beautify some code

    * Make sure to use the correct language

    * Add SeString Creator widget

    * Fix getting local parameters

    * Update expressionNames

    * misc changes

    * Use InvariantCulture in TryResolveSheet

    * Add SeStringEvaluatorAgingStep

    * Fix item id comparisons

    * Add SheetRedirectResolverAgingStep

    * Add NounProcessorAgingStep

    * Update SeString.CreateItemLink

    This also adds the internal ItemUtil class.

    * Fix name of SeStringCreator widget

    * Add Global Parameters tab to SeStringCreatorWidget

    * Load widgets on demand

    * Update SeStringCreatorWidget

    * Resizable SeStringCreatorWidget panels

    * Update GamepadStateAgingStep

    * Experimental status was removed in goatcorp#2144

    * Update SheetRedirectResolver, rewrite Noun params

    * Fixes for 4 am code

    * Remove incorrect column offset

    I have no idea how that happened.

    * Draw names of linked things

    ---------

    Co-authored-by: Soreepeong <[email protected]>
    Co-authored-by: KazWolfe <[email protected]>

commit 7cac19c
Author: marzent <[email protected]>
Date:   Mon Mar 24 16:42:24 2025 +0100

    Implement dalamud-platform launch argument (goatcorp#1452)

    * implement dalamud platform launch arg
    * implement cross-platform gamePath fallback
    * refactor platform detection heuristic
    * add cross platform dalamud runtime detection

commit 9815cf1
Author: Vanillaaaa <[email protected]>
Date:   Mon Mar 24 12:38:47 2025 +0800

    perf: show whether plugin toggle is enable or disable (goatcorp#2189)

commit 8939cac
Author: Kaz Wolfe <[email protected]>
Date:   Sun Mar 23 18:45:15 2025 -0700

    fix: actually add values

commit aaa3e33
Author: Kaz Wolfe <[email protected]>
Date:   Sun Mar 23 18:37:44 2025 -0700

    chore: PluginLoadReason is flags

commit e846540
Author: Kaz Wolfe <[email protected]>
Date:   Sun Mar 23 18:28:07 2025 -0700

    fix: Force devs to choose between ValueClamped and ValueUnclamped

commit 3074115
Author: Kaz Wolfe <[email protected]>
Date:   Sun Mar 23 18:27:48 2025 -0700

    chore: Add api 13 tracker

commit 1676522
Author: goat <[email protected]>
Date:   Sun Dec 29 16:53:16 2024 +0100

    clamp value of all easings by default

    (cherry picked from commit 1aada98)

commit c3df199
Author: Kaz Wolfe <[email protected]>
Date:   Sun Mar 23 18:12:41 2025 -0700

    chore: Obsolete accessing ObjectTable off main thread

commit 6a1cea7
Author: Kaz Wolfe <[email protected]>
Date:   Sun Mar 23 18:11:03 2025 -0700

    chore: remove obsoleted AppendMacroString methods

commit 23c8701
Author: Ethan Henderson <[email protected]>
Date:   Sun Mar 23 16:14:16 2025 -0600

    add(DRKGauge): Add `DeliriumComboStep`, and its enum `DeliriumStep` (goatcorp#2198)

commit 82dd462
Author: Ethan Henderson <[email protected]>
Date:   Sun Mar 23 16:13:27 2025 -0600

    SMNGauge: Fix typo, update CS (goatcorp#2197)

    * chore(SMNGauge): update gauge to latest CS struct
    * chore(SMNGauge): Fix `AttunementTimerRemaining` typo
    * refactor(SMNGauge): Cast `AttunementType` to a new enum instead of leaving it raw
    * fix(SMNGauge): Use `AttunementType` for `Is<X>Attuned`

commit a2124bb
Author: KazWolfe <[email protected]>
Date:   Thu Mar 13 14:16:28 2025 -0700

    fix: Attempt to better handle hook disposal (goatcorp#1803)

    - Use a Weak Concurrent Collection to track scoped hooks
    - Make `Hook`s remove themselves from the Tracked Hook list.

commit 203d80c
Author: Nathan C <[email protected]>
Date:   Thu Mar 13 17:01:39 2025 -0400

    Build adjustments for code annotation (goatcorp#2155)

    * Drop special formatting, allowing annotations to work properly.

    * Suppress duplicate warnings, adding a prefix to prevent annotation

    * Tweak message, don't rebuild on test

    * Move testing into same job step

    * Only run PR build on newly opened PRs

    * flip build order, derp

    * Test suppressing summary for annotations...

    * Get the build order right, testing without conditionals...

    * Run tests after compile, suppress warnings from test

    * Reverted previous change to `main.yml`.

    * Drop special formatting, allowing annotations to work properly.

    * Suppress duplicate warnings, adding a prefix to prevent annotation

    * Tweak message, don't rebuild on test

    * Move testing into same job step

    * Only run PR build on newly opened PRs

    * flip build order, derp

    * Test suppressing summary for annotations...

    * Get the build order right, testing without conditionals...

    * Run tests after compile, suppress warnings from test

    * Reverted previous change to `main.yml`.

    * Drop special formatting, allowing annotations to work properly.

    * Suppress duplicate warnings, adding a prefix to prevent annotation

    * Tweak message, don't rebuild on test

    * Move testing into same job step

    * Only run PR build on newly opened PRs

    * flip build order, derp

    * Test suppressing summary for annotations...

    * Get the build order right, testing without conditionals...

    * Run tests after compile, suppress warnings from test

    * Reverted previous change to `main.yml`.

    * Add conditional for CI builds, add --skip-tests to make up for the combined build/test step.

    * Behavior change, now requires arg `ci` to be passed to trigger tests. Tests can also be manually triggered with `test`.

commit 2c00bf5
Merge: 2e2c73f 18e19f7
Author: goat <[email protected]>
Date:   Thu Mar 13 21:57:01 2025 +0100

    Merge pull request goatcorp#2195 from goatcorp/net9-rollup

    [net9] Rollup changes from master

commit 18e19f7
Merge: 2e2c73f 2f0c31d
Author: github-actions[bot] <[email protected]>
Date:   Thu Mar 13 19:34:36 2025 +0000

    Merge remote-tracking branch 'origin/master' into net9-rollup

commit 2e2c73f
Author: bleatbot <[email protected]>
Date:   Wed Mar 12 23:27:12 2025 +0100

    [net9] Rollup changes from master (goatcorp#2193)

    * feat: handle UNC paths in FileDialog (goatcorp#2191)

    * Remove command from assembly map when removed from command map (goatcorp#2183)

    ---------

    Co-authored-by: Alex Vallière <[email protected]>
    Co-authored-by: Blair <[email protected]>
    Co-authored-by: github-actions[bot] <[email protected]>

commit 97add3f
Author: goaaats <[email protected]>
Date:   Wed Mar 12 23:23:31 2025 +0100

    Globally disable legacy corrupted state exceptions for now

commit b21a0c9
Author: goaaats <[email protected]>
Date:   Sun Mar 9 19:34:26 2025 +0100

    Add console argument/env var to disable legacy corrupted state exceptions policy

commit cf1d8a8
Author: goaaats <[email protected]>
Date:   Sat Mar 8 16:27:10 2025 +0100

    Remove obsolete ServicePointManager TLS version override

commit 89dfd72
Author: goat <[email protected]>
Date:   Sat Mar 8 16:13:54 2025 +0100

    ci: build with 9.0.200 SDK

commit 6604678
Merge: a7faabd 01b3a54
Author: goaaats <[email protected]>
Date:   Sat Mar 8 16:10:25 2025 +0100

    merge from master

commit a7faabd
Merge: df3900f f9bdceb
Author: KazWolfe <[email protected]>
Date:   Tue Dec 17 08:14:45 2024 -0800

    [net9] Rollup changes from master (goatcorp#2133)

    * Use MiniGame BGM scene for About tab

    * Use span comparison in GameGui.IsInLobby

    * [master] Update ClientStructs (goatcorp#2126)

    Co-authored-by: github-actions[bot] <[email protected]>

    * [master] Update ClientStructs (goatcorp#2134)

    Co-authored-by: github-actions[bot] <[email protected]>

    * [master] Update ClientStructs (goatcorp#2135)

    Co-authored-by: github-actions[bot] <[email protected]>

    * Fix config option summaries (goatcorp#2138)

    * Fix config option summaries

    * Obsolete LockonDefaultZoom_179 with error

    * Don't allow nameplate GameObject lookup when ObjectId is invalid (goatcorp#2137)

    * build: 11.0.2.0

    * Update ClientStructs (goatcorp#2139)

    Co-authored-by: github-actions[bot] <[email protected]>

    * chore: remove [Experimental] from SeStringRenderer (goatcorp#2144)

    It hasn't caused problem for a while (though performance probably can be
    better), and looks good enough to remove this attribute.

    * Update ClientStructs (goatcorp#2140)

    Co-authored-by: github-actions[bot] <[email protected]>

    * Return nullable on XivChatType.GetDetails (goatcorp#2143)

    ---------

    Co-authored-by: Haselnussbomber <[email protected]>
    Co-authored-by: github-actions[bot] <[email protected]>
    Co-authored-by: nebel <[email protected]>
    Co-authored-by: goat <[email protected]>
    Co-authored-by: goat <[email protected]>
    Co-authored-by: srkizer <[email protected]>

commit f9bdceb
Merge: df3900f 3ccd93a
Author: github-actions[bot] <[email protected]>
Date:   Tue Dec 17 15:57:14 2024 +0000

    Merge remote-tracking branch 'origin/master' into net9-rollup

commit df3900f
Merge: 26be395 73072d7
Author: KazWolfe <[email protected]>
Date:   Thu Nov 28 09:32:22 2024 -0800

    Merge pull request goatcorp#2102 from goatcorp/net9-rollup

    [net9] Rollup changes from master

commit 73072d7
Merge: 26be395 1830af5
Author: github-actions[bot] <[email protected]>
Date:   Thu Nov 28 17:19:34 2024 +0000

    Merge remote-tracking branch 'origin/master' into net9-rollup

commit 26be395
Merge: e187749 a8f3098
Author: goat <[email protected]>
Date:   Sun Nov 17 14:36:39 2024 +0100

    Merge pull request goatcorp#2087 from goatcorp/net9-rollup

    [net9] Rollup changes from master

commit a8f3098
Merge: e187749 dc10ba4
Author: github-actions[bot] <[email protected]>
Date:   Sun Nov 17 13:36:00 2024 +0000

    Merge remote-tracking branch 'origin/master' into net9-rollup

commit e187749
Merge: 23cdf3c 605c301
Author: goat <[email protected]>
Date:   Fri Nov 15 19:42:00 2024 +0100

    Merge pull request goatcorp#2086 from goatcorp/net9-rollup

    [net9] Rollup changes from master

commit 605c301
Merge: 23cdf3c a5b0a38
Author: github-actions[bot] <[email protected]>
Date:   Fri Nov 15 18:34:17 2024 +0000

    Merge remote-tracking branch 'origin/master' into net9-rollup

commit 23cdf3c
Merge: a5622f3 d7abf9f
Author: Kaz Wolfe <[email protected]>
Date:   Thu Nov 14 23:29:14 2024 -0800

    Merge branch 'api11' into net9

commit a5622f3
Author: goat <[email protected]>
Date:   Thu Nov 14 01:16:51 2024 +0100

    possibly work around nuke .NET9 issue

commit 6efa41d
Author: goat <[email protected]>
Date:   Thu Nov 14 01:08:39 2024 +0100

    use net9 SDK in CI

commit 9d4bc95
Author: goat <[email protected]>
Date:   Thu Nov 14 01:08:07 2024 +0100

    initial net9 port
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfcomp wolfcomp wolfcomp left review comments

@goaaats goaaats goaaats approved these changes

@KazWolfe KazWolfe Awaiting requested review from KazWolfe

Assignees

@KazWolfe KazWolfe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nathanctech @wolfcomp @KazWolfe @goaaats